How to fix siren bug?

[VHCal]

I believe I have set up my sirens correctly but I am having problems with the KFRS vehicles.

 

 

LASiren.script

[itchboy]

What exactly is wrong with this? I dont have any idea what is wrong unless you tell me in particular what happens. Does it crash upon selecting a vehicle? Error when playing command? Or nothing happens when pressing the command?

[VHCal]

1 minute ago, itchboy said:

What exactly is wrong with this? I dont have any idea what is wrong unless you tell me in particular what happens. Does it crash upon selecting a vehicle? Error when playing command? Or nothing happens when pressing the command?

Sorry, I didn't explain it very well. Upon pressing the siren button nothing happens for certain vehicles.

No crash happens.

[itchboy]

Which ones to be specific? Can I have their prototype names?

[VHCal]

Just now, itchboy said:

Which ones to be specific? Can I have their prototype names?

Sure, they are:

const char CAR_50[] = "mod:Prototypes/Vehicles/Kent FRS/Nissan.e4p";
const char CAR_51[] = "mod:Prototypes/Vehicles/Kent FRS/Officer_car.e4p";
const char CAR_52[] = "mod:Prototypes/Vehicles/Kent FRS/Sprinter.e4p";
const char CAR_53[] = "mod:Prototypes/Vehicles/Kent FRS/Incident.e4p";

[itchboy]

Try using else if conditions instead of making them all as 'if' conditions. My first theory is that you have far too many 'if' conditions and the game stops reading that set because you have too many. Try grouping them by 10 at most.

Another question is, do you have the correct prototypes up in the top? Some people come here complaining about issues but then it ends up being a spelling error with the prototype name.

[VHCal]

3 minutes ago, itchboy said:

Try using else if conditions instead of making them all as 'if' conditions. My first theory is that you have far too many 'if' conditions and the game stops reading that set because you have too many. Try grouping them by 10 at most.

Another question is, do you have the correct prototypes up in the top? Some people come here complaining about issues but then it ends up being a spelling error with the prototype name.

Okay seems a bit wired to just stop working, will give it a try.

I have checked the prototypes and spelling seems to be fine. Just strange that it's only fire vehicles that aren't working.

 

Thanks for the reply.

[itchboy]

Do the vehicles from 54-61 work?

[VHCal]

Just now, itchboy said:

Do the vehicles from 54-61 work?

Yes

[itchboy]

http://pastebin.com/VG1urwxP

Some code I tried. Replaces your entire siren script. Link expires in 60 minutes.

[VHCal]

8 minutes ago, itchboy said:

http://pastebin.com/VG1urwxP

Some code I tried. Replaces your entire siren script. Link expires in 60 minutes.

That crashed the script therefore it wouldn't work

Edited May 16, 2016 by VHCal

[itchboy]

At what line did it crash. Keep pressing 'retry' and let me know what line it goes.

[VHCal]

4 minutes ago, itchboy said:

At what line did it crash. Keep pressing 'retry' and let me know what line it goes.

It's line 352 then goes on about adding -p 

[itchboy]

Thing is, there is no line 352, which means this is a bracket bug on my part. Does it crash when using the command or only highlighting over the vehicle?

Might be line 163 actually

 

if (StrCompare(v.GetPrototypeFileName(), CAR_31) == 0 || StrCompare(v.GetPrototypeFileName(), CAR_32) == 0 ||

The || at the end of car 32 is missing.

if (StrCompare(v.GetPrototypeFileName(), CAR_17) == 0 || StrCompare(v.GetPrototypeFileName(), CAR_20) == 0 ||

Same issue with line 144. Car 20 is missing the ||

I'm not particularly good at scripting, but I at least tried to tidy up your code.

[VHCal]

47 minutes ago, itchboy said:

Thing is, there is no line 352, which means this is a bracket bug on my part. Does it crash when using the command or only highlighting over the vehicle?

It crashes upon start-up and the siren icon isn't there.

[itchboy]

Starting the game? Try the above things I listed.

[VHCal]

11 hours ago, itchboy said:

Starting the game? Try the above things I listed.

Ah okay I will take a look into it, thanks.

[Chris07]

EOF refers to end of file. The script is reaching the end of file before it wants to. That means you're probably missing a bracket

[itchboy]

3 hours ago, Chris07 said:

EOF refers to end of file. The script is reaching the end of file before it wants to. That means you're probably missing a bracket

I am missing more than just a bracket, it would seem I am missing 2 different || 'or' lines.

[amuchalipsis]

Try this one. Just add one of these commands to the cars to make the siren sound:

DummySirenWhelenAlpha
DummySirenWhelenAlpha2
DummySirenWhelenGamma
DummySirenWhelen295
DummySirenPH7009
DummySirenWoodwayCommander3
DummySirenPremiumHazard

 

 

LASiren.script

[itchboy]

2 hours ago, amuchalipsis said:

Try this one. Just add one of these commands to the cars to make the siren sound:

DummySirenWhelenAlpha
DummySirenWhelenAlpha2
DummySirenWhelenGamma
DummySirenWhelen295
DummySirenPH7009
DummySirenWoodwayCommander3
DummySirenPremiumHazard

 

 

http://www.emergency-planet.com/applications/core/interface/file/attachment.php?id=17851

While this method also works, it is quite messy becuase it involves adding more commands, and means a lot of editor work for the end user. Another drawback is that the mod will take much longer to load if you add numerous dummy commands. Each solution has its plus and minuses, but its up to OP to decide.

[VHCal]

6 hours ago, itchboy said:

While this method also works, it is quite messy becuase it involves adding more commands, and means a lot of editor work for the end user. Another drawback is that the mod will take much longer to load if you add numerous dummy commands. Each solution has its plus and minuses, but its up to OP to decide.

I would prefer to script the vehicles into the mod as it would be neater 

 

---------UPDATE-----------

I fixed it by adding 

if (StrCompare(v.GetPrototypeFileName(), CAR_98) == 0)
		soundID = Audio::PlaySample3D("mod:Audio/FX/Sirens/PH7009.wav", CarPos, true);

and that seemed to work. Thanks for everyone's input! 

Edited May 18, 2016 by VHCal

[amuchalipsis]

On 18/5/2016 at 5:20 PM, itchboy said:

While this method also works, it is quite messy becuase it involves adding more commands, and means a lot of editor work for the end user. Another drawback is that the mod will take much longer to load if you add numerous dummy commands. Each solution has its plus and minuses, but its up to OP to decide.

Thanks for the info. I didn't know that, I guess one never ends a day without learning something new